Lose ends, nonsense, things unresoleved and unexplained that made for a bad movie:

Who was the first character shown (never saw the face) and what was their purpose?
I believe that was the person that came to tell the King & Queen how to have a child.

Who was the person and what was her "condition", that upset Salma in the beginning?
She was just an entertainer but she was pregnant and thus that upset the Queen who couldn't conceive.

How is it that Salma was the only person in the movie with a Spanish accent?
It wasn't unusual back in the day for a King/Prince to marry a Queen/Princess from another kingdom to
set up an alliance between the kingdoms.

Why was Joshua in the forest and how/why was he injured?
My guess is he went out to hunt for food. He fell through the roof of the cave and was injured from the fall.

What was the point of the spring coming out of the tree when nothing made of it other than ducks bathing in it?
Joshua told Elias that as long as that water ran clear, Elias would know that Joshua was safe. That's why when the water
turned red; Elias went looking for Joshua.

How did diver Dan breathe under water when he killed the iguana? There were no hoses or tanks and that suit would have held about two breaths worth of air.
Not sure, but it is a fairytale so everything goes!

How did Violet's rescuers get the rope to the ogre side?
Another fairytale! But they were obviously performers!

Why didn't the horny king have to reload a single shot, single barrel gun after firing, when he was hunting the pig or was he gonna look like a schmuck and dry fire??
He probably never really shot anything anyway, but always took the credit.

Why was it not explained why Joshua boned out? Assumably, he was under some sort of threat and I think the story would have benefited if it were explained.
The Queen had tried to kill him, that's why he left.

What was the deal with Violet at the end? Was she made queen? Did king Toby abdicate?
She was made Queen.

Was Elias king since Salma was dead and if so, what about Josh?
Elias returned Josh to his wife and then Elias returned home. He was King as his mother was dead; however,
he was to be made King on his 18th birthday anyway.