Good, but . . .
I enjoyed this movie, but in my opinion, 'The Shop Around the Corner' with Jimmy Stewart and Margaret Sullavan was much better.
For those of you who do not know . . . the story featured in 'In the Good Old Summertime' (1949) and later in 'You've Got Mail' (1998) also appeared earlier in 'The Shop Around the Corner' (1940), which was directed by Ernst Lubitsch.
I think all 3 are enjoyable films--but there's something about 1940 version which seems much sweeter. I think it was better-acted, the story was simpler, and I felt there was better chemistry between the leads.
In this version, I found Van Johnson's performance to be somewhat one-dimensional, and I think (the great) Buster Keaton was mis-cast. I also think the violin subplot distracted from the love story, and I didn't like the moments of "slapstick" that showed up in a few parts. I did, however, like Judy Garland (of course), and I also like the performance of S.Z. Sakall (Mr. Oberkugen).
As a movie lover, I can appreciate all 3 of the films--but I just wanted to draw attention to the earlier great movie.
That's my 2 cents.